#123 closed
Scriptish

Closing issue #120

Reported by Scriptish | September 18th, 2011 @ 09:51 PM

  • ScriptIcon was allowing _downloadURL to be set for incorrect schemes (e.g. "dattta").

  • The above problem let ScriptDownloader.fetchDependencies add the icon (with a bad downloadURL) to the list of dependencies to download.

  • These commits:

    • make sure the icon's downloadURL is at least valid in format before setting it
    • allow ScriptDownloader to continue fetching any subsequent dependencies after a possible failed @icon download
    • reset the script icon if invalid

https://github.com/supahgreg/scriptish/compare/issue-120

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Shared Ticket Bins

People watching this ticket